-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'url' property with a description that was difficult to write in … #1492
Conversation
…the ccontext of the existing xref property
Thank you @sierra-moxon.It's nice, simple and it works for me. |
@codewarrior2000 - thanks Larry! The thing I am slightly worried about is that for your reactome example, to fully represent both reactome links on a single node, you'd have one I'm also a little worried that the definition of Per our discussion, this property is also single-valued (assuming that in TRAPI, many such attributes will be submitted in the TRAPI message when necessary). How will that be stored in the data store? Perhaps this is unnecessary for me to know, but I am trying to imagine how a non-Translator user would use this slot if they need to represent more than one of these kinds of URLs for a particular node. |
@sierra-moxon, thank you. Is there a Biolink Model requirement that I am not aware of that requires both links? |
@sierra-moxon |
@sierra-moxon |
thanks @codewarrior2000 and @vdancik! TL;DR:
Sort of self-explanatory, but Biolink is used for KGs other than those currently in Translator and I think without TRAPI its difficult for a user of Biolink to use our proposed
For example, the same CURIE that represents a mouse gene can be used in many URLs to see different views of that gene at MGI: https://www.informatics.jax.org/marker/MGI:97486 <-- the full gene page at MGI, the default URI expansion of the curie: This is a very similar use case as the reactome use case. If we chose the But those other two MGI links are also valid, and take the user to a different view of the data. So similarly, we'd argue in this PR, that those two other MGI links are not
Perhaps we should require that if an At a minimum I think we need text descriptions that help disambiguate and I would welcome help here, of course. :) |
@sierra-moxon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sierra-moxon A few typos :D
Unlink -> Unlike
can not -> cannot
an unique -> a unique
per code review, fix typos
…the context of the existing xref property
for your review @codewarrior2000
fixes ##1486